[TR-34] Property values for single-pass indexing are not scaled Created: 23/Feb/10  Updated: 24/Feb/10  Resolved: 24/Feb/10

Status: Resolved
Project: Terrier Core
Component/s: .indexing, .utility
Affects Version/s: 2.2.1
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Philipp Sorg Assignee: Craig Macdonald
Resolution: Fixed  
Labels: None

Issue Links:
Related
is related to TR-100 Revisit default and sample terrier.pr... Resolved

 Description   
The value of property "memory.reserved" is interpreted as bytes, and not in MB as stated in the sample property file.
The value of "memory.heap.usage" is interpreted as real number, and not as percentage.

When using the default settings (memory.reserved=50, memory.heap.usage=85), the condition in RuntimeMemoryChecker therefore never gets true and the intermediate runs are not written to disk. When indexing large datasets, this leads to out of memory exceptions.

Maybe it would be a good idea to check the valid range of these properties and output a warning.

 Comments   
Comment by Craig Macdonald [ 23/Feb/10 ]

Thanks for the heads up about the sample properties file. I have added suitable checks to the relevant Terrier class for checking that these properties are properly set in the future.

Comment by Craig Macdonald [ 24/Feb/10 ]

Committed to trunk. Thanks!

Generated at Sun Jul 12 13:16:04 BST 2020 using JIRA 7.1.1#71004-sha1:d6b2c0d9b7051e9fb5e4eb8ce177ca56d91d7bd8.