[TR-330] Make SimpleXMLCollection be quiet Created: 25/Feb/15  Updated: 06/Nov/15  Resolved: 06/Nov/15

Status: Resolved
Project: Terrier Core
Component/s: .indexing
Affects Version/s: 4.0
Fix Version/s: 4.1

Type: Bug Priority: Trivial
Reporter: Ian Soboroff Assignee: Craig Macdonald
Resolution: Fixed  
Labels: None


 Description   
SimpleXMLCollectijon prints debugging messages to System.err on attribute nodes. Other similar lines are commented out. Here is the patch:

--- SimpleXMLCollection.java.orig 2015-02-25 10:29:36.000000000 -0500
+++ SimpleXMLCollection.java 2015-02-25 10:29:49.000000000 -0500
@@ -169,7 +169,7 @@
  {
  String attributeName = (parentNodeName +
  ELEMENT_ATTR_SEPARATOR + n.getNodeName()).toLowerCase();
- System.err.println("ATTRIBUTE NODE " + attributeName+" "+n.getNodeValue());
+ // System.err.println("ATTRIBUTE NODE " + attributeName+" "+n.getNodeValue());
  if(DocIdIsAttribute && attributeName.equals(DocIdLocation))
  ThisDocId = n.getNodeValue().replaceAll("\n","");
  if(PropertiesInAttibutes && PropertyElements.containsKey(attributeName))


 Comments   
Comment by Ian Soboroff [ 25/Feb/15 ]

Actually this class is chock full of println statements that should either be cleaned out or wrapped in the logger. But I don't have the patience to do that

Comment by Craig Macdonald [ 25/Feb/15 ]

Agreed. My bad I think.

Comment by Craig Macdonald [ 06/Nov/15 ]

marking for 4.1

Comment by Craig Macdonald [ 06/Nov/15 ]

Already fixed as per move to git.

Generated at Sat Dec 16 18:29:55 GMT 2017 using JIRA 7.1.1#71004-sha1:d6b2c0d9b7051e9fb5e4eb8ce177ca56d91d7bd8.