TR-223.patch
[TR-223] Refactoring/Cleaning up of the package org.terrier.matching.models Created: 18/Dec/12 Updated: 31/Mar/14 Resolved: 31/Mar/14 |
|
| Status: | Resolved |
| Project: | Terrier Core |
| Component/s: | .matching |
| Affects Version/s: | 3.5 |
| Fix Version/s: | 3.6 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Francois Rousseau | Assignee: | Craig Macdonald |
| Resolution: | Fixed | ||
| Labels: | None | ||
| Attachments: |
TR-223.patch
|
| Description |
|
There are some inconsistencies in the package org.terrier.matching.models: - style guide rules (lines too long, empty lines full of tabs, unreadable score definitions) - final methods that prevent inheritance (BM25, TF_IDF) - missing library to standardize tf normalizations (sublinearity, length normalization...) - log definition in the Idf class that should be deprecated and moved to the new library |
| Comments |
| Comment by Francois Rousseau [ 18/Dec/12 ] |
|
Patch related to the issue. Aiming at version 4.0 ant test passes successfully. MAP on disks 4&5 (same as current version 3.5) for:
|
| Comment by Francois Rousseau [ 07/Jan/13 ] |
|
New patch. For the tf normalizations's library, it's actually concave and not sublinear that we want. |
| Comment by Richard McCreadie [ 31/Mar/14 ] |
|
Integrated patch into the Terrier 3.5 build. Contains many javadoc additions and refactoring of IDF functions into a new WeightingModelLibrary class. |
| Comment by Richard McCreadie [ 31/Mar/14 ] |
|
Committed version 3759. |
| Comment by Richard McCreadie [ 31/Mar/14 ] |
|
Closing issue, will add note in Terrier 3.6 release issue to check java doc consistency for matching.models |