[TR-204] Relevance feedback for query expansion in queries without relevance judgements could throw NullPointerException Created: 22/Jun/12  Updated: 23/Jul/12  Resolved: 23/Jul/12

Status: Resolved
Project: Terrier Core
Component/s: .querying
Affects Version/s: 3.5
Fix Version/s: 3.6

Type: Bug Priority: Minor
Reporter: Saúl Vargas Assignee: Craig Macdonald
Resolution: Fixed  
Labels: None


 Description   
Error case: given the query 95 of the TREC Web Track 2010, with no associated relevance judgements, the RelevanceFeedbackSelector class for query expansion will return null when method getFeedbackDocuments is called. This behaviour leads to RelevantOnlyFeedbackDocuments throwing a NullPointerException in line 59 since parentReturn is null.

Proposal: return an empty list in RelevanceFeedbackSelector or handle a null value in RelevantOnlyFeedbackDocuments. (Even simpler, the user should remove this kind of queries.)

 Comments   
Comment by Craig Macdonald [ 23/Jul/12 ]

Simple change, line 100 in RelevanceFeedbackSelector should return an empty array.

Thanks Saul!

Comment by Craig Macdonald [ 23/Jul/12 ]

Committed r3638

Generated at Sat Dec 16 16:47:37 GMT 2017 using JIRA 7.1.1#71004-sha1:d6b2c0d9b7051e9fb5e4eb8ce177ca56d91d7bd8.