[TR-203] MRF formula applies w_o twice Created: 18/Jun/12  Updated: 24/Jul/12  Resolved: 24/Jul/12

Status: Resolved
Project: Terrier Core
Component/s: .matching
Affects Version/s: 3.5
Fix Version/s: 3.6

Type: Bug Priority: Trivial
Reporter: SungBin Choi Assignee: Craig Macdonald
Resolution: Fixed  
Labels: None


 Description   

Terrier 3.5
org.terrier.matching.dsms.MRFDependenceScoreModifier.java
linenumber : 68


Regarding this MRFDependence scoring formula
[linenumber68] return w_o * (Idf.log(1 + (tf/(mu * (defaultCf / super.numTokens))) ) + Idf.log(mu/(docLength+mu)));
I'm worried about that first term(w_o) should be removed from this formula,
because weight(w_o or w_u) will be combined in DFRDependenceScoreModifier.java

Please check out above formula, and let me know if I'm wrong.

Thank you.


 Comments   
Comment by Craig Macdonald [ 18/Jun/12 ]

When you said DFRDependenceScoreModifier you should have said DependenceScoreModifier.java, but you are correct, this is a bug. We will correct this for the next release of Terrier. Good spot!

Comment by Craig Macdonald [ 24/Jul/12 ]

Patch is remove w_o from line 68.

Comment by Craig Macdonald [ 24/Jul/12 ]

Updated title.

Comment by Craig Macdonald [ 24/Jul/12 ]

committed r3639

Generated at Sat Dec 16 16:51:27 GMT 2017 using JIRA 7.1.1#71004-sha1:d6b2c0d9b7051e9fb5e4eb8ce177ca56d91d7bd8.