Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-95

FSArrayFile.ArrayFileIterator.skip() doesnt update entry index correctly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: .structures
    • Labels:
      None

      Description

      FSArrayFile.ArrayFileIterator.skip() doesn't update entry index correctly. This can mean reading BitPostings in MR mode will not behave as expected incorrectly - indeed, some splits may even be empty!

        Attachments

          Activity

          Hide
          craigm Craig Macdonald added a comment -

          If there had been a unit test for FSArrayFile, this would have been easily caught.

          Show
          craigm Craig Macdonald added a comment - If there had been a unit test for FSArrayFile, this would have been easily caught.
          Hide
          craigm Craig Macdonald added a comment -

          Resolution of bug was trivial. I also added a Junit test case to ensure that FSArrayFile behaves as expected.

          Show
          craigm Craig Macdonald added a comment - Resolution of bug was trivial. I also added a Junit test case to ensure that FSArrayFile behaves as expected.

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              craigm Craig Macdonald
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: