Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-86

Matching should be an interface

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: .matching
    • Labels:
      None

      Description

      Some sub-classes of Matching are over complicated because Matching loads indices etc. We need to refactor here - the basic Matching instance should do less.

      Having it as an interface would be one direction:

      {code}
      public interface Matching
      {
       public ResultSet match(String queryNumber, MatchingQueryTerms queryTerms) throws IOException;
      }
      {code}

      A minimal abstract class would be another.
      {code}
      public abstract class Matching
      {
       Index index;
       public Matching(Index _index) { this.index = _index; }
       public abstract ResultSet match(String queryNumber, MatchingQueryTerms queryTerms) throws IOException;
      }
      {code}

        Attachments

          Issue Links

            Activity

            craigm Craig Macdonald created issue -
            craigm Craig Macdonald made changes -
            Field Original Value New Value
            Link This issue is blocked by TREC-74 [ TREC-74 ]
            craigm Craig Macdonald made changes -
            Assignee Iadh Ounis [ ounis ] Craig Macdonald [ craigm ]
            craigm Craig Macdonald made changes -
            Fix Version/s 3.0 [ 10020 ]
            craigm Craig Macdonald made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            craigm Craig Macdonald made changes -
            Project TREC [ 10010 ] Terrier Core [ 10000 ]
            Key TREC-128 TR-86
            Workflow jira [ 10248 ] Terrier Open Source [ 10344 ]
            Component/s .matching [ 10004 ]
            Component/s Core [ 10020 ]
            Fix Version/s 3.0 [ 10030 ]
            Fix Version/s 3.0 [ 10020 ]

              People

              • Assignee:
                craigm Craig Macdonald
                Reporter:
                craigm Craig Macdonald
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: