Details
Description
Some sub-classes of Matching are over complicated because Matching loads indices etc. We need to refactor here - the basic Matching instance should do less.
Having it as an interface would be one direction:
{code}
public interface Matching
{
public ResultSet match(String queryNumber, MatchingQueryTerms queryTerms) throws IOException;
}
{code}
A minimal abstract class would be another.
{code}
public abstract class Matching
{
Index index;
public Matching(Index _index) { this.index = _index; }
public abstract ResultSet match(String queryNumber, MatchingQueryTerms queryTerms) throws IOException;
}
{code}
Having it as an interface would be one direction:
{code}
public interface Matching
{
public ResultSet match(String queryNumber, MatchingQueryTerms queryTerms) throws IOException;
}
{code}
A minimal abstract class would be another.
{code}
public abstract class Matching
{
Index index;
public Matching(Index _index) { this.index = _index; }
public abstract ResultSet match(String queryNumber, MatchingQueryTerms queryTerms) throws IOException;
}
{code}
Attachments
Issue Links
- is blocked by
-
TR-60 Remove PonteCroft language modelling
-
- Resolved
-
Easier to do if LMMatching was moved into common before doing this.