Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: .applications, .structures
    • Labels:
      None

      Description

      TRECQuery is the class responsible for extracting queries from a TREC topics file.
      It also has a sub-class called SingleLineTRECQuery for topics files in a different format.
      Both files assumes that all the queries from the files can be loaded in memory.

      However, for processing queries from a large query log, this seems unlikely.

      TRECQuery should be refactored, (and probably moved out of the structures package, where it doesn't belong). It should probably represent some Iterator interface instead.

        Attachments

          Activity

          craigm Craig Macdonald created issue -
          Hide
          craigm Craig Macdonald added a comment -
          interface BatchOfQueries extends Iterator<String>
          {
           //inherits: public boolean hasNext();
           //inherits: public String next();
           public String getQueryId();
          }
          

          question: interface or abstract class?
          question: should this be an interface in TRECQuerying, since this is the only place it is used?

          Show
          craigm Craig Macdonald added a comment - interface BatchOfQueries extends Iterator< String > { //inherits: public boolean hasNext(); //inherits: public String next(); public String getQueryId(); } question: interface or abstract class? question: should this be an interface in TRECQuerying, since this is the only place it is used?
          Hide
          craigm Craig Macdonald added a comment -

          Resolved. Added a QuerySource interface in TRECQuerying. Refactored TRECQuery to use interface, and deprecated older methods.

          Show
          craigm Craig Macdonald added a comment - Resolved. Added a QuerySource interface in TRECQuerying. Refactored TRECQuery to use interface, and deprecated older methods.
          craigm Craig Macdonald made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          craigm Craig Macdonald made changes -
          Affects Version/s 3.0 [ 10020 ]
          Fix Version/s 3.0 [ 10020 ]
          craigm Craig Macdonald made changes -
          Project TREC [ 10010 ] Terrier Core [ 10000 ]
          Key TREC-82 TR-66
          Issue Type Improvement [ 4 ] Bug [ 1 ]
          Workflow jira [ 10177 ] Terrier Open Source [ 10324 ]
          Affects Version/s 3.0 [ 10030 ]
          Affects Version/s 3.0 [ 10020 ]
          Component/s .applications [ 10001 ]
          Component/s .structures [ 10007 ]
          Component/s Core [ 10020 ]
          Fix Version/s 3.0 [ 10030 ]
          Fix Version/s 3.0 [ 10020 ]

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              craigm Craig Macdonald
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: