Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-459

Manager.runSearchRequest should call all of the other manager.run methods

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2
    • Component/s: .querying
    • Labels:
      None

      Description

      Documenting the use of the Manager API would be easier if we didn't have to document each of the run_() methods.

      Please insert a method, described in comment below.

        Attachments

          Activity

          Hide
          craigm Craig Macdonald added a comment -
           public void runSearchRequest(SearchRequest srq)
           {
            this.runPreprocesses(srq);
            this.runMatching(srq);
            this.runPostProcess(srq);
            this.runPostFilters(srq);
           }
          

          Change the documentation in Manager.java, and all places where the older run_ methods appear in the documentation.

          Craig

          Show
          craigm Craig Macdonald added a comment - public void runSearchRequest(SearchRequest srq) { this .runPreprocesses(srq); this .runMatching(srq); this .runPostProcess(srq); this .runPostFilters(srq); } Change the documentation in Manager.java, and all places where the older run_ methods appear in the documentation. Craig
          Hide
          richardm Richard McCreadie added a comment -

          Change to Manager committed to 4.2.1 1e61504a

          Show
          richardm Richard McCreadie added a comment - Change to Manager committed to 4.2.1 1e61504a
          Hide
          richardm Richard McCreadie added a comment -

          Comments addressed and doc updated. Closing issue.

          Show
          richardm Richard McCreadie added a comment - Comments addressed and doc updated. Closing issue.

            People

            • Assignee:
              richardm Richard McCreadie
              Reporter:
              craigm Craig Macdonald
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: