Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-39

DocID's are not assigned correctly during the reduce step of MapReduce Indexing.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: .indexing, .structures
    • Labels:
      None

      Description

      There is a bad assumption that splits will be allocated to maps in order, i.e that split 1 will be given to Map1 etc.

      Fix: Sort the MapData files by start DocID and when assigning these to reduces use this ordering.

        Attachments

        1. TREC-34.v4.patch
          34 kB
        2. TREC-34.v3.patch
          27 kB
        3. TR-34.branch2x.v4.patch
          31 kB
        4. patch.txt
          31 kB

          Activity

          Hide
          craigm Craig Macdonald added a comment -

          Improved patch. Appears to fix docids properly. Prevents double flushes, and keeps all indexer variables at correct values.

          Show
          craigm Craig Macdonald added a comment - Improved patch. Appears to fix docids properly. Prevents double flushes, and keeps all indexer variables at correct values.
          Hide
          craigm Craig Macdonald added a comment -

          Richard,

          I'm wondering if this patch could be back-ported to Terrier 2, as block indexing is taking an age. (Dont do anything yet)

          C

          Show
          craigm Craig Macdonald added a comment - Richard, I'm wondering if this patch could be back-ported to Terrier 2, as block indexing is taking an age. (Dont do anything yet) C
          Hide
          craigm Craig Macdonald added a comment -

          Last revision of patch. This patch for trunk only.

          Show
          craigm Craig Macdonald added a comment - Last revision of patch. This patch for trunk only.
          Hide
          craigm Craig Macdonald added a comment -

          Patch committed for trunk.

          Show
          craigm Craig Macdonald added a comment - Patch committed for trunk.
          Hide
          craigm Craig Macdonald added a comment -

          patch for 2.x SVN branch (rev 2573). All tests pass.

          Show
          craigm Craig Macdonald added a comment - patch for 2.x SVN branch (rev 2573). All tests pass.

            People

            • Assignee:
              richardm Richard McCreadie
              Reporter:
              richardm Richard McCreadie
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: