Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-363

incorrect assertion in RandomDataInputMemory.java

          Details

          • Type: Bug
          • Status: Resolved
          • Priority: Trivial
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: 4.1
          • Component/s: None
          • Labels:
            None

            Description

            I don't follow the logic of this assertion


            public final void seek(long _pos)
            {
                        assert(pos < 0);


              Attachments

                Issue Links

                relates to

                Improvement - An improvement or enhancement to an existing feature or task. TR-354 Unit tests should pass with assertions enabled

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • Resolved

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  craigm Craig Macdonald added a comment -

                  Given that the following line is:
                  this.pos = _pos;
                  what would actually make sense is:
                  assert(pos >= 0);

                  Show
                  craigm Craig Macdonald added a comment - Given that the following line is: this.pos = _pos; what would actually make sense is: assert(pos >= 0);
                  Hide
                  Permalink
                  craigm Craig Macdonald added a comment -

                  All unit test pass; committed r4007.

                  Show
                  craigm Craig Macdonald added a comment - All unit test pass; committed r4007.

                    People

                    • Assignee:
                      craigm Craig Macdonald
                      Reporter:
                      craigm Craig Macdonald
                    • Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: