Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-330

Make SimpleXMLCollection be quiet

          Details

          • Type: Bug
          • Status: Resolved
          • Priority: Trivial
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: 4.1
          • Component/s: .indexing
          • Labels:
            None

            Description

            SimpleXMLCollectijon prints debugging messages to System.err on attribute nodes. Other similar lines are commented out. Here is the patch:

            --- SimpleXMLCollection.java.orig 2015-02-25 10:29:36.000000000 -0500
            +++ SimpleXMLCollection.java 2015-02-25 10:29:49.000000000 -0500
            @@ -169,7 +169,7 @@
              {
              String attributeName = (parentNodeName +
              ELEMENT_ATTR_SEPARATOR + n.getNodeName()).toLowerCase();
            - System.err.println("ATTRIBUTE NODE " + attributeName+" "+n.getNodeValue());
            + // System.err.println("ATTRIBUTE NODE " + attributeName+" "+n.getNodeValue());
              if(DocIdIsAttribute && attributeName.equals(DocIdLocation))
              ThisDocId = n.getNodeValue().replaceAll("\n","");
              if(PropertiesInAttibutes && PropertyElements.containsKey(attributeName))

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                isoboroff Ian Soboroff added a comment -

                Actually this class is chock full of println statements that should either be cleaned out or wrapped in the logger. But I don't have the patience to do that

                Show
                isoboroff Ian Soboroff added a comment - Actually this class is chock full of println statements that should either be cleaned out or wrapped in the logger. But I don't have the patience to do that
                Hide
                Permalink
                craigm Craig Macdonald added a comment -

                Agreed. My bad I think.

                Show
                craigm Craig Macdonald added a comment - Agreed. My bad I think.
                Hide
                Permalink
                craigm Craig Macdonald added a comment -

                marking for 4.1

                Show
                craigm Craig Macdonald added a comment - marking for 4.1
                Hide
                Permalink
                craigm Craig Macdonald added a comment -

                Already fixed as per move to git.

                Show
                craigm Craig Macdonald added a comment - Already fixed as per move to git.

                  People

                  • Assignee:
                    craigm Craig Macdonald
                    Reporter:
                    isoboroff Ian Soboroff
                  • Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: