Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-307

PostingIndex.getPostings(POINTERTYPE extends Pointer lEntry) becomes PostingIndex.getPostings(Pointer lEntry)

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 4.0
    • Component/s: None
    • Labels:
      None

      Description

      The move to the use of generic PostingIndex structures for the Direct and Inverted indices causes errors in the DependenceScoreModifier.openPostingLists() method, since the POINTERTYPE or index.getInvertedIndex().getPostings() is not known a priori. The assumption that DependenceScoreModifier.openPostingLists() makes is that POINTERTYPE is LexconEntry or extends LexconEntry, e.g. MemoryLexiconEntry. However, getInvertedIndex() returns a PostingIndex<Pointer>, i.e. is more generic.

      Since when an index calls PostingIndex.getPostings() POINTERTYPE is generic (type Pointer), the method should only type check for '? extends Pointer' rather than 'is POINTERTYPE that extends Pointer'.

        Attachments

          Activity

          richardm Richard McCreadie created issue -
          richardm Richard McCreadie made changes -
          Field Original Value New Value
          Assignee Iadh Ounis [ ounis ] Richard McCreadie [ richardm ]
          Hide
          richardm Richard McCreadie added a comment -

          This change API change seems to have been accepted. Resolving.

          Show
          richardm Richard McCreadie added a comment - This change API change seems to have been accepted. Resolving.
          richardm Richard McCreadie made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          richardm Richard McCreadie made changes -
          Project TREC [ 10010 ] Terrier Core [ 10000 ]
          Key TREC-358 TR-307
          Workflow jira [ 10798 ] Terrier Open Source [ 10870 ]
          Affects Version/s 3.6 [ 10060 ]
          Affects Version/s 3.6 [ 10061 ]
          Component/s Core [ 10020 ]
          Fix Version/s 4.0 [ 10051 ]
          Fix Version/s 4.0 [ 10050 ]
          richardm Richard McCreadie made changes -
          Summary 4.0 API: PostingIndex.getPostings(POINTERTYPE extends Pointer lEntry) becomes PostingIndex.getPostings(Pointer lEntry) PostingIndex.getPostings(POINTERTYPE extends Pointer lEntry) becomes PostingIndex.getPostings(Pointer lEntry)

            People

            • Assignee:
              richardm Richard McCreadie
              Reporter:
              richardm Richard McCreadie
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: