Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-300

(Block)Inverted2Direct should not use old int[][] getNextDocuments()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 4.0
    • Component/s: None
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          craigm Craig Macdonald created issue -
          Hide
          craigm Craig Macdonald added a comment -

          work-in-progress alterations

          Show
          craigm Craig Macdonald added a comment - work-in-progress alterations
          craigm Craig Macdonald made changes -
          Field Original Value New Value
          Attachment BlockInverted2DirectIndexBuilder.java [ 10404 ]
          Attachment Inverted2DirectIndexBuilder.java [ 10405 ]
          craigm Craig Macdonald made changes -
          Link This issue blocks TREC-368 [ TREC-368 ]
          Hide
          richardm Richard McCreadie added a comment -

          I have a working version of Inverted2DirectIndexBuilder and BlockInverted2DirectIndexBuilder for Terrier 4.0 based on these classes.

          Additional methods were added to PostingUtil.

          All unit tests pass.

          @craig Please delete your attachments and ill replace them with the new versions

          Marked for resolution

          Show
          richardm Richard McCreadie added a comment - I have a working version of Inverted2DirectIndexBuilder and BlockInverted2DirectIndexBuilder for Terrier 4.0 based on these classes. Additional methods were added to PostingUtil. All unit tests pass. @craig Please delete your attachments and ill replace them with the new versions Marked for resolution
          craigm Craig Macdonald made changes -
          Attachment BlockInverted2DirectIndexBuilder.java [ 10404 ]
          craigm Craig Macdonald made changes -
          Attachment Inverted2DirectIndexBuilder.java [ 10405 ]
          richardm Richard McCreadie made changes -
          Attachment BlockInverted2DirectIndexBuilder.java [ 10408 ]
          Attachment Inverted2DirectIndexBuilder.java [ 10409 ]
          Attachment PostingUtil.java [ 10410 ]
          Hide
          richardm Richard McCreadie added a comment -

          Terrier 4.0 versions attached

          Show
          richardm Richard McCreadie added a comment - Terrier 4.0 versions attached
          Hide
          craigm Craig Macdonald added a comment -

          Can you make attach a patch?

          Show
          craigm Craig Macdonald added a comment - Can you make attach a patch?
          Hide
          richardm Richard McCreadie added a comment -

          On the patch, to what version?

          4.0 before the changes or 3.6?

          Show
          richardm Richard McCreadie added a comment - On the patch, to what version? 4.0 before the changes or 3.6?
          Hide
          craigm Craig Macdonald added a comment -

          Either is fine, surely?

          Show
          craigm Craig Macdonald added a comment - Either is fine, surely?
          Hide
          richardm Richard McCreadie added a comment -

          Patch version against early 4.0 build

          Show
          richardm Richard McCreadie added a comment - Patch version against early 4.0 build
          richardm Richard McCreadie made changes -
          Attachment TR-371.patch [ 10411 ]
          craigm Craig Macdonald made changes -
          Link This issue blocks TREC-373 [ TREC-373 ]
          craigm Craig Macdonald made changes -
          Link This issue is duplicated by TREC-306 [ TREC-306 ]
          Hide
          craigm Craig Macdonald added a comment -

          Committed r3789

          Show
          craigm Craig Macdonald added a comment - Committed r3789
          craigm Craig Macdonald made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          craigm Craig Macdonald made changes -
          Link This issue is duplicated by TREC-318 [ TREC-318 ]
          richardm Richard McCreadie made changes -
          Project TREC [ 10010 ] Terrier Core [ 10000 ]
          Key TREC-371 TR-300
          Workflow jira [ 10815 ] Terrier Open Source [ 10863 ]
          Affects Version/s 3.6 [ 10060 ]
          Affects Version/s 3.6 [ 10061 ]
          Component/s Common [ 10032 ]
          Fix Version/s 4.0 [ 10051 ]
          Fix Version/s 4.0 [ 10050 ]

            People

            • Assignee:
              richardm Richard McCreadie
              Reporter:
              craigm Craig Macdonald
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: