Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-290

Integer compression properties should be more uniform with others

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Component/s: None
    • Labels:
      None

      Description

      See
      http://terrier.org/issues/browse/TREC-334?focusedCommentId=11434&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_11434

      Various places also need to change:
       - unit tests
       - and IntegerCodecCompressionConfiguration

        Attachments

          Issue Links

            Activity

            craigm Craig Macdonald created issue -
            craigm Craig Macdonald made changes -
            Field Original Value New Value
            Link This issue relates to TR-283 [ TR-283 ]
            craigm Craig Macdonald made changes -
            Link This issue relates to TREC-334 [ TREC-334 ]
            craigm Craig Macdonald made changes -
            Link This issue relates to TR-283 [ TR-283 ]
            Hide
            richardm Richard McCreadie added a comment -

            Index recompressor needs to change too

            Show
            richardm Richard McCreadie added a comment - Index recompressor needs to change too
            Hide
            richardm Richard McCreadie added a comment -

            indexing.direct.compression.configuration and indexing.inverted.compression.configuration are the main compression configuration properties.

            E.g.

            #this property is ok
            indexing.direct.compression.configuration=org.terrier.structures.integer.indexing.IntegerCodecCompressionConfiguration
            #these properties should be renamed indexing.inverted.compression.integer....
            compression.inverted.integer.ids.codec=LemireFORVBCodec
            compression.inverted.integer.tfs.codec=LemireFORVBCodec
            compression.inverted.integer.fields.codec=LemireFORVBCodec
            compression.inverted.integer.blocks.codec=LemireFORVBCodec
            #this property should be specific to the structure also
            compression.integer.chunk.size=1024
            
            Show
            richardm Richard McCreadie added a comment - indexing.direct.compression.configuration and indexing.inverted.compression.configuration are the main compression configuration properties. E.g. #this property is ok indexing.direct.compression.configuration=org.terrier.structures.integer.indexing.IntegerCodecCompressionConfiguration #these properties should be renamed indexing.inverted.compression.integer.... compression.inverted.integer.ids.codec=LemireFORVBCodec compression.inverted.integer.tfs.codec=LemireFORVBCodec compression.inverted.integer.fields.codec=LemireFORVBCodec compression.inverted.integer.blocks.codec=LemireFORVBCodec #this property should be specific to the structure also compression.integer.chunk.size=1024
            Hide
            richardm Richard McCreadie added a comment - - edited

            Switched format slightly (indexing->index) to make it consistent with existing properties where appropriate:

            indexing.structureName.compression.configuration=IntegerCodecCompressionConfiguration

            index.structureName.compression.integer.ids.codec=LemireFORVBCodec
            index.structureName.compression.integer.tfs.codec=LemireFORVBCodec
            index.structureName.compression.integer.fields.codec=LemireFORVBCodec
            index.structureName.compression.integer.blocks.codec=LemireFORVBCodec
            index.structureName.compression.integer.chunk.size=1024

            Show
            richardm Richard McCreadie added a comment - - edited Switched format slightly (indexing->index) to make it consistent with existing properties where appropriate: indexing.structureName.compression.configuration=IntegerCodecCompressionConfiguration index.structureName.compression.integer.ids.codec=LemireFORVBCodec index.structureName.compression.integer.tfs.codec=LemireFORVBCodec index.structureName.compression.integer.fields.codec=LemireFORVBCodec index.structureName.compression.integer.blocks.codec=LemireFORVBCodec index.structureName.compression.integer.chunk.size=1024
            Hide
            richardm Richard McCreadie added a comment -

            Committed r3868

            Show
            richardm Richard McCreadie added a comment - Committed r3868
            richardm Richard McCreadie made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            richardm Richard McCreadie made changes -
            Project TREC [ 10010 ] Terrier Core [ 10000 ]
            Key TREC-387 TR-290
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            Workflow jira [ 10833 ] Terrier Open Source [ 10853 ]
            Component/s Core [ 10020 ]
            Fix Version/s 4.0 [ 10051 ]
            Fix Version/s 4.0 [ 10050 ]

              People

              • Assignee:
                richardm Richard McCreadie
                Reporter:
                craigm Craig Macdonald
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: