Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-274

Block Shakespeare tests are failing

          Details

          • Type: Bug
          • Status: Resolved
          • Priority: Blocker
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 3.6
          • Component/s: None
          • Labels:
            None

            Description

            Query count was 8 instead of 9 expected:<9> but was:<8>
            junit.framework.AssertionFailedError: Query count was 8 instead of 9 expected:<9> but was:<8>
                at org.terrier.tests.BatchEndToEndTest.doEvaluation(BatchEndToEndTest.java:175)
                at org.terrier.tests.BatchEndToEndTest.doTrecTerrierRunAndEvaluate(BatchEndToEndTest.java:231)
                at org.terrier.tests.BatchEndToEndTest.doTrecTerrierIndexingRunAndEvaluate(BatchEndToEndTest.java:207)
                at org.terrier.tests.BasicShakespeareEndToEndTest.testBasicClassical(BasicShakespeareEndToEndTest.java:49)

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                craigm Craig Macdonald created issue -
                Hide
                Permalink
                craigm Craig Macdonald added a comment -

                I found the issue in PhraseScoreModifers's use of IterablePosting.next(int). I also added unit tests for TestPhraseIterablePosting and TestPhraseScoreModifier.

                Show
                craigm Craig Macdonald added a comment - I found the issue in PhraseScoreModifers's use of IterablePosting.next(int). I also added unit tests for TestPhraseIterablePosting and TestPhraseScoreModifier.
                craigm Craig Macdonald made changes -
                Field Original Value New Value
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                richardm Richard McCreadie made changes -
                Project TREC [ 10010 ] Terrier Core [ 10000 ]
                Key TREC-314 TR-274
                Workflow jira [ 10677 ] Terrier Open Source [ 10792 ]
                Component/s Core [ 10020 ]
                Fix Version/s 3.6 [ 10060 ]
                Fix Version/s 3.6 [ 10061 ]

                  People

                  • Assignee:
                    craigm Craig Macdonald
                    Reporter:
                    craigm Craig Macdonald
                  • Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: