Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-268

Query term counting doesn't work

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: None
    • Labels:
      None

      Description

      Report by email

      {{{
      In the function:
      public void runPreProcessing(SearchRequest srq)
      of the class:
      org.terrier.querying.Manager

      There is a line:
      query.obtainQueryTerms(queryTerms)

      This line tries to assign the weight for the query terms based on their
      occurrences in the query. However, in this version of terrier, the
      weight is always 1.0 for the term, regardless of its times of occurrences.

      I think in terrier 3.0, the implantation is correct. Thanks a lot for
      your consideration.
      }}}

        Attachments

          Issue Links

            Activity

            craigm Craig Macdonald created issue -
            Hide
            craigm Craig Macdonald added a comment -

            Tagging for 3.6. I have a unit test showing that can reproduce this bug.

            Show
            craigm Craig Macdonald added a comment - Tagging for 3.6. I have a unit test showing that can reproduce this bug.
            craigm Craig Macdonald made changes -
            Field Original Value New Value
            Fix Version/s 3.6 [ 10061 ]
            Hide
            craigm Craig Macdonald added a comment -

            Reported by Bo Li, from imag.fr

            Show
            craigm Craig Macdonald added a comment - Reported by Bo Li, from imag.fr
            craigm Craig Macdonald made changes -
            Summary Query term counting doesn't work? Query term counting doesn't work
            Hide
            craigm Craig Macdonald added a comment -

            Patch committed to MatchingQueryTerms, r3641

            Show
            craigm Craig Macdonald added a comment - Patch committed to MatchingQueryTerms, r3641
            craigm Craig Macdonald made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            craigm Craig Macdonald added a comment -

            This causes TestMatchingQueryTerms to fail.

            Show
            craigm Craig Macdonald added a comment - This causes TestMatchingQueryTerms to fail.
            craigm Craig Macdonald made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            Hide
            craigm Craig Macdonald added a comment -

            Committed r3653. SingleTermQuery now uses MQT.addTermProperty(), not setTermProperty().

            Show
            craigm Craig Macdonald added a comment - Committed r3653. SingleTermQuery now uses MQT.addTermProperty(), not setTermProperty().
            craigm Craig Macdonald made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            craigm Craig Macdonald made changes -
            Link This issue is duplicated by TR-242 [ TR-242 ]
            richardm Richard McCreadie made changes -
            Project TREC [ 10010 ] Terrier Core [ 10000 ]
            Key TREC-293 TR-268
            Workflow jira [ 10630 ] Terrier Open Source [ 10786 ]
            Affects Version/s 3.5 [ 10040 ]
            Affects Version/s 3.5 [ 10021 ]
            Component/s Core [ 10020 ]
            Fix Version/s 3.6 [ 10060 ]
            Fix Version/s 3.6 [ 10061 ]

              People

              • Assignee:
                craigm Craig Macdonald
                Reporter:
                craigm Craig Macdonald
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: