Details
Major
Description
Attachments
Activity
Related note:
The patch uses the local isInWindow method rather than Distance.noTimes method
Either implementation should be valid, but each will be faster in different use cases.
isInWindow will be faster for long documents when the query terms appear only rarely. (Complexity: |Q| . window . occurences(Q,d))
Distance.noTimes will be faster when the query terms appear often in a document. (Complexity: |Q| . documentLength-window)
Do you have numbers to prove this?
Also, does isInWindow() pass similar tests to Distance.noTimes
Could the method be moved to the Distance class, to keep everything in the same place?
Did a test of Distance.noTimes for the proximity, but it fails all of the tests. Looking at the Distance test case, I think that noTimes is looking for n-grams not term sets in windows.
If so, it is not applicable for this issue.
Current implementation passes all of the unit tests. Resolving this issue.
Query language documentation should be updated to describe what this functionality does and how it differs from proximity score modifiers.
Committed patch and test case for interpretation 'All query terms must be contained within a window of n terms'. Window is set to num_query_terms if window is less than num_query_terms.
Commit 3754.
Resolve?