Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-223

Refactoring/Cleaning up of the package org.terrier.matching.models

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: .matching
    • Labels:
      None

      Description

      There are some inconsistencies in the package org.terrier.matching.models:
      - style guide rules (lines too long, empty lines full of tabs, unreadable score definitions)
      - final methods that prevent inheritance (BM25, TF_IDF)
      - missing library to standardize tf normalizations (sublinearity, length normalization...)
      - log definition in the Idf class that should be deprecated and moved to the new library

        Attachments

          Activity

          frousseau Francois Rousseau created issue -
          frousseau Francois Rousseau made changes -
          Field Original Value New Value
          Attachment TR-223.patch [ 10372 ]
          frousseau Francois Rousseau made changes -
          Attachment TR-223.patch [ 10372 ]
          frousseau Francois Rousseau made changes -
          Attachment TR-223.patch [ 10374 ]
          frousseau Francois Rousseau made changes -
          Attachment TR-223.patch [ 10375 ]
          frousseau Francois Rousseau made changes -
          Attachment TR-223.patch [ 10374 ]
          craigm Craig Macdonald made changes -
          Fix Version/s 3.6 [ 10060 ]
          richardm Richard McCreadie made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              frousseau Francois Rousseau
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: