Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-222

Remove the deprecated 5-param score method in favor of the 2-param method

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 4.1
    • Component/s: .matching
    • Labels:
      None

      Description

      For 3.6, deprecate the 5-param score method in all the weighting models under the package org.terrier.matching.models.
      For 4.0, remove the 5-param score method to avoid duplicated code.

        Attachments

          Issue Links

            Activity

            frousseau Francois Rousseau created issue -
            Hide
            frousseau Francois Rousseau added a comment - - edited

            Patch that deprecates the 5-param method in all the weighting models under org.terrier.matching.models package.

            ant test passes successfully.

            MAP on disks 4&5 (same as current version) for:

            • BB2 (0.2412) c=1.0
            • BM25 (0.2502) c=0.3444
            • DFI0 (0.2390)
            • DFR_BM25 (0.2043) c=0.3444
            • DFRee (0.2488)
            • DirichletLM (0.2324) mu=2500
            • DLH (0.2368)
            • DLH13 (0.2437)
            • DPH (0.2479)
            • Hiemstra_LM (0.2167) c=0.15
            • IFB2 (0.2400) c=1.0
            • In_expB2 (0.2408) c=1.0
            • In_expC2 (0.2336) c=1.0
            • InB2 (0.2392) c=1.0
            • InL2 (0.2405) c=1.0
            • Js_KLs (0.2504)
            • LemurTF_IDF (0.2273)
            • LGD (0.2484) c=1.0
            • PL2 (0.2538) c=9.15
            • TF-IDF (0.2508) c=0.3444
            • XSqrA_M (0.2477)
            Show
            frousseau Francois Rousseau added a comment - - edited Patch that deprecates the 5-param method in all the weighting models under org.terrier.matching.models package. ant test passes successfully. MAP on disks 4&5 (same as current version) for: BB2 (0.2412) c=1.0 BM25 (0.2502) c=0.3444 DFI0 (0.2390) DFR_BM25 (0.2043) c=0.3444 DFRee (0.2488) DirichletLM (0.2324) mu=2500 DLH (0.2368) DLH13 (0.2437) DPH (0.2479) Hiemstra_LM (0.2167) c=0.15 IFB2 (0.2400) c=1.0 In_expB2 (0.2408) c=1.0 In_expC2 (0.2336) c=1.0 InB2 (0.2392) c=1.0 InL2 (0.2405) c=1.0 Js_KLs (0.2504) LemurTF_IDF (0.2273) LGD (0.2484) c=1.0 PL2 (0.2538) c=9.15 TF-IDF (0.2508) c=0.3444 XSqrA_M (0.2477)
            frousseau Francois Rousseau made changes -
            Field Original Value New Value
            Attachment TR-222.patch [ 10371 ]
            frousseau Francois Rousseau made changes -
            Attachment TR-222.patch [ 10371 ]
            frousseau Francois Rousseau made changes -
            Attachment TR-222.patch [ 10373 ]
            craigm Craig Macdonald made changes -
            Fix Version/s 4.0 [ 10051 ]
            craigm Craig Macdonald made changes -
            Link This issue is blocked by TR-231 [ TR-231 ]
            craigm Craig Macdonald made changes -
            Summary Deprecate the 5-param score method in favor of the 2-param method Remove the deprecated 5-param score method in favor of the 2-param method
            Hide
            richardm Richard McCreadie added a comment -

            Too soon after the 3.6 release for this change, tagging for 4.1

            Show
            richardm Richard McCreadie added a comment - Too soon after the 3.6 release for this change, tagging for 4.1
            richardm Richard McCreadie made changes -
            Fix Version/s 4.1 [ 10070 ]
            Fix Version/s 4.0 [ 10051 ]
            craigm Craig Macdonald made changes -
            Status Open [ 1 ] Patch Available [ 10000 ]
            Hide
            craigm Craig Macdonald added a comment -

            Committed for v4.1

            Show
            craigm Craig Macdonald added a comment - Committed for v4.1
            craigm Craig Macdonald made changes -
            Status Patch Available [ 10000 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]

              People

              • Assignee:
                craigm Craig Macdonald
                Reporter:
                frousseau Francois Rousseau
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: