Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-207

Adhoc Evaluation returns bad precision at percent

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: .querying
    • Labels:
      None

      Description

      When I run trec_terrier.sh -e, I get a .eval file with precision at rank and precision at percent values.
      The precision at percent values seems wrong. I get sometimes values bigger than 1, whereas these values should be between 0 and 1.

      I've joined a fix for this. See attachment.

        Attachments

          Activity

          Hide
          richardm Richard McCreadie added a comment -

          Patch seems reasonable, changes 'adjustOrPutValue' to 'put'. Committed patch to 3745.

          Show
          richardm Richard McCreadie added a comment - Patch seems reasonable, changes 'adjustOrPutValue' to 'put'. Committed patch to 3745.
          Hide
          sadi.samy Sadi Samy added a comment -

          No example for a unit test sorry. But here is typical example of a .eval file I get after running trecterrier.sh -e.

          Show
          sadi.samy Sadi Samy added a comment - No example for a unit test sorry. But here is typical example of a .eval file I get after running trecterrier.sh -e.
          Hide
          craigm Craig Macdonald added a comment -

          Tagging for 3.6

          Show
          craigm Craig Macdonald added a comment - Tagging for 3.6
          Hide
          craigm Craig Macdonald added a comment -

          Hi Sadi,

          Thanks for this. Do you have a concrete example that I could make into a unit test?

          Show
          craigm Craig Macdonald added a comment - Hi Sadi, Thanks for this. Do you have a concrete example that I could make into a unit test?

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              sadi.samy Sadi Samy
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: