Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-204

Relevance feedback for query expansion in queries without relevance judgements could throw NullPointerException

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: .querying
    • Labels:
      None

      Description

      Error case: given the query 95 of the TREC Web Track 2010, with no associated relevance judgements, the RelevanceFeedbackSelector class for query expansion will return null when method getFeedbackDocuments is called. This behaviour leads to RelevantOnlyFeedbackDocuments throwing a NullPointerException in line 59 since parentReturn is null.

      Proposal: return an empty list in RelevanceFeedbackSelector or handle a null value in RelevantOnlyFeedbackDocuments. (Even simpler, the user should remove this kind of queries.)

        Attachments

          Activity

          Hide
          craigm Craig Macdonald added a comment -

          Committed r3638

          Show
          craigm Craig Macdonald added a comment - Committed r3638
          Hide
          craigm Craig Macdonald added a comment -

          Simple change, line 100 in RelevanceFeedbackSelector should return an empty array.

          Thanks Saul!

          Show
          craigm Craig Macdonald added a comment - Simple change, line 100 in RelevanceFeedbackSelector should return an empty array. Thanks Saul!

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              saulvargas Saúl Vargas
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: