Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: .matching
    • Labels:
      None

      Description


      Terrier 3.5
      org.terrier.matching.dsms.MRFDependenceScoreModifier.java
      linenumber : 68


      Regarding this MRFDependence scoring formula
      [linenumber68] return w_o * (Idf.log(1 + (tf/(mu * (defaultCf / super.numTokens))) ) + Idf.log(mu/(docLength+mu)));
      I'm worried about that first term(w_o) should be removed from this formula,
      because weight(w_o or w_u) will be combined in DFRDependenceScoreModifier.java

      Please check out above formula, and let me know if I'm wrong.

      Thank you.

        Attachments

          Activity

          Hide
          craigm Craig Macdonald added a comment -

          When you said DFRDependenceScoreModifier you should have said DependenceScoreModifier.java, but you are correct, this is a bug. We will correct this for the next release of Terrier. Good spot!

          Show
          craigm Craig Macdonald added a comment - When you said DFRDependenceScoreModifier you should have said DependenceScoreModifier.java, but you are correct, this is a bug. We will correct this for the next release of Terrier. Good spot!
          Hide
          craigm Craig Macdonald added a comment -

          Patch is remove w_o from line 68.

          Show
          craigm Craig Macdonald added a comment - Patch is remove w_o from line 68.
          Hide
          craigm Craig Macdonald added a comment -

          Updated title.

          Show
          craigm Craig Macdonald added a comment - Updated title.
          Hide
          craigm Craig Macdonald added a comment -

          committed r3639

          Show
          craigm Craig Macdonald added a comment - committed r3639

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              wakeup06 SungBin Choi
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: