Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-198

Conservative QE incorrectly weights queryterms

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: .querying
    • Labels:
      None

      Description

      In the class org.terrier.querying.DFRBagExpansionTerms (subclass of org.terrier.querying.ExpansionTerms) the "Conservative QE" won't work because the variable int i (line 170) is not incremented while iterating over the set of original query terms, i.e., the variable SingleTermQuery[] results (line 151) won't be properly filled.

      Possible patch attached.

        Attachments

          Activity

          saulvargas Saúl Vargas created issue -
          Hide
          craigm Craig Macdonald added a comment -

          Great catch Saul!

          Show
          craigm Craig Macdonald added a comment - Great catch Saul!
          craigm Craig Macdonald made changes -
          Field Original Value New Value
          Summary Conservative QE won't work Conservative QE incorrectly weights queryterms
          Priority Major [ 3 ] Trivial [ 5 ]
          Fix Version/s 3.6 [ 10060 ]
          Hide
          craigm Craig Macdonald added a comment -

          Committed r3617

          Show
          craigm Craig Macdonald added a comment - Committed r3617
          craigm Craig Macdonald made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              saulvargas Saúl Vargas
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: