Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-179

BitIn implementations should both inherit from a common base class

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: .compression
    • Labels:
      None

      Description

      BitFileBuffered.BitInBuffered and BitInputStream both have a create deal of very similar code. They should instead inherit from a common base class that contains as much common code as possible, e.g. readUnary(), readBinary() etc. etc.

        Attachments

          Activity

          Hide
          craigm Craig Macdonald added a comment -

          Committed, r3643

          Show
          craigm Craig Macdonald added a comment - Committed, r3643
          Hide
          craigm Craig Macdonald added a comment -

          Updated title, tagging for 3.6

          Show
          craigm Craig Macdonald added a comment - Updated title, tagging for 3.6

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              craigm Craig Macdonald
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: