Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-163

Index does not explicily close the properties file

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.5
    • Component/s: .structures
    • Labels:
      None

      Description

      The terrier index object creates an unreferenced input stream to load the properties file from. Once loading is complete Java will garbage collect the stream. However, if many index objects are loaded in sequence and at a fast enough rate, Java will not garbage collect fast enough to close all of the streams, leading to a FileNotFound error due to too many open files.

      The InputStream should be explicitly declared and closed after reading.

        Attachments

          Activity

          richardm Richard McCreadie created issue -
          Hide
          richardm Richard McCreadie added a comment -

          Fixed and committed 3405

          Show
          richardm Richard McCreadie added a comment - Fixed and committed 3405
          richardm Richard McCreadie made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          craigm Craig Macdonald made changes -
          Summary The Terrier index does not explicily close the properties file Index does not explicily close the properties file
          Priority Major [ 3 ] Trivial [ 5 ]
          Assignee Iadh Ounis [ ounis ] Richard McCreadie [ richardm ]
          Fix Version/s 3.1 [ 10021 ]
          craigm Craig Macdonald made changes -
          Project TREC [ 10010 ] Terrier Core [ 10000 ]
          Key TREC-246 TR-163
          Workflow jira [ 10557 ] Terrier Open Source [ 10565 ]
          Affects Version/s 3.0 [ 10030 ]
          Affects Version/s 3.0 [ 10020 ]
          Component/s .structures [ 10007 ]
          Component/s Core [ 10020 ]
          Fix Version/s 3.1 [ 10040 ]
          Fix Version/s 3.1 [ 10021 ]

            People

            • Assignee:
              richardm Richard McCreadie
              Reporter:
              richardm Richard McCreadie
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: