Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-142

Matching implementations should not overwrite the EntryStatistics stored in the MatchingQueryTerms object

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.5
    • Component/s: .matching
    • Labels:
      None

      Description

      Matching implementations should not overwrite the EntryStatistics stored in the MatchingQueryTerms object.

      This bug was difficult to find, but easy to fix. However, a test case is absolutely required due to the subtlety of the bug. Matching implementations don't yet have test cases.

        Attachments

          Activity

          craigm Craig Macdonald created issue -
          Hide
          craigm Craig Macdonald added a comment -

          This was resolved by adding a check in BaseMatching. Additionally, unit tests for Matching were introduced, which also cover this test case.

          Show
          craigm Craig Macdonald added a comment - This was resolved by adding a check in BaseMatching. Additionally, unit tests for Matching were introduced, which also cover this test case.
          craigm Craig Macdonald made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Richard McCreadie [ richardm ] Craig Macdonald [ craigm ]
          Fix Version/s 3.1 [ 10021 ]
          Resolution Fixed [ 1 ]
          craigm Craig Macdonald made changes -
          Project TREC [ 10010 ] Terrier Core [ 10000 ]
          Key TREC-206 TR-142
          Workflow jira [ 10463 ] Terrier Open Source [ 10535 ]
          Affects Version/s 3.0 [ 10030 ]
          Affects Version/s 3.0 [ 10020 ]
          Component/s .matching [ 10004 ]
          Component/s Core [ 10020 ]
          Component/s Distributed [ 10030 ]
          Fix Version/s 3.1 [ 10040 ]
          Fix Version/s 3.1 [ 10021 ]

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              craigm Craig Macdonald
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: