Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-142

Matching implementations should not overwrite the EntryStatistics stored in the MatchingQueryTerms object

          Details

          • Type: Bug
          • Status: Resolved
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.0
          • Fix Version/s: 3.5
          • Component/s: .matching
          • Labels:
            None

            Description

            Matching implementations should not overwrite the EntryStatistics stored in the MatchingQueryTerms object.

            This bug was difficult to find, but easy to fix. However, a test case is absolutely required due to the subtlety of the bug. Matching implementations don't yet have test cases.

              Attachments

                Activity

                Hide
                Permalink
                craigm Craig Macdonald added a comment -

                This was resolved by adding a check in BaseMatching. Additionally, unit tests for Matching were introduced, which also cover this test case.

                Show
                craigm Craig Macdonald added a comment - This was resolved by adding a check in BaseMatching. Additionally, unit tests for Matching were introduced, which also cover this test case.

                  People

                  • Assignee:
                    craigm Craig Macdonald
                    Reporter:
                    craigm Craig Macdonald
                  • Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: