Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-131

Parsing of WeightingModel class names could be better

          Details

          • Type: Bug
          • Status: Resolved
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 3.5
          • Component/s: .matching
          • Labels:
            None

            Description

            Currently, we parse WeightingModel class names in the following manner:
            DPH => uk.ac.gla.terrier.matching.models.DPH ("DPH" doesnt contain a ., so add package).
            However, this breaks if the weighting model has parameters, e.g.:
            DFRWeightingModel(uk.ac.gla.terrier.matching.models.basicmodel.P, L, 2)

            We need a bit more intelligence in how the brackets are parsed.

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                craigm Craig Macdonald added a comment -

                Tagged for 3.1

                Show
                craigm Craig Macdonald added a comment - Tagged for 3.1
                Hide
                Permalink
                rodrygo Rodrygo L. T. Santos added a comment -

                Fixed WeightingModelFactory accordingly.

                Show
                rodrygo Rodrygo L. T. Santos added a comment - Fixed WeightingModelFactory accordingly.

                  People

                  • Assignee:
                    rodrygo Rodrygo L. T. Santos
                    Reporter:
                    craigm Craig Macdonald
                  • Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: