Uploaded image for project: 'Terrier Core'
  1. Terrier Core
  2. TR-112

"Term Not Found" log message should not be a warning

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.5
    • Component/s: None
    • Labels:
      None

      Description

      BaseMatching issues a "Term Not Found" message at WARN level. OldBasicMatching issues the same message at INFO level. I would suggest logging these messages at INFO or even DEBUG level in both cases.

        Attachments

          Activity

          Hide
          craigm Craig Macdonald added a comment -

          What's the case for each?

          Here are my opinions:

          • WARN - its normal that terms arent found, so WARN isnt appropriate
          • INFO - is term not found too regular that it warrants an INFO message
          • DEBUG - might be suppressed and could useful to know when lots of terms are not found.

          My preference is leaning towards DEBUG.

          Show
          craigm Craig Macdonald added a comment - What's the case for each? Here are my opinions: WARN - its normal that terms arent found, so WARN isnt appropriate INFO - is term not found too regular that it warrants an INFO message DEBUG - might be suppressed and could useful to know when lots of terms are not found. My preference is leaning towards DEBUG.
          Hide
          rec Richard Eckart de Castilho added a comment -

          I follow that argumentation and second DEBUG.

          Show
          rec Richard Eckart de Castilho added a comment - I follow that argumentation and second DEBUG.
          Hide
          craigm Craig Macdonald added a comment -

          Tagging for 3.1

          Show
          craigm Craig Macdonald added a comment - Tagging for 3.1
          Hide
          craigm Craig Macdonald added a comment -

          Committed to trunk.

          Show
          craigm Craig Macdonald added a comment - Committed to trunk.

            People

            • Assignee:
              craigm Craig Macdonald
              Reporter:
              rec Richard Eckart de Castilho
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: